Lazy publishableKey config#59
Merged
lindyhopchris merged 2 commits intocode-corps:developfrom Aug 10, 2019
Merged
Conversation
josemarluedke
force-pushed
the
lazy-config
branch
from
bd395a7 to
95a9804
Compare
Contributor
|
Thanks for this! Looks good. The only thing that occurs to me is do we know what happens if |
Contributor
Author
|
That's a good question. I don't know the consequences of that. However, we do prevent calling configure if it was already configured, so I guess that's safe. I guess this PR does not fix #39. |
Contributor
|
Yeah, need to clarify whether toggling the publishable key is a requirement and/or even possible. But this PR is great at the mo so will merge for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53.